Skip to content

Conversation

@364220158
Copy link
Contributor

fix issues #774

@FlechazoW
Copy link
Member

你好,我刚review了提交的pr,存在两个问题:
(1)我们合并代码的前提是,commit message 要符合我们的规范,规范是:[hotfix/feature/doc-#issueID][fix-module] fix-commit.
(2)变量命名不规范;

image

[hotfix/feature/doc-#774][chunjun-connector-oraclelogminer]  fix UNISTR cannot parse string
[hotfix -DTStack#774][chunjun-connector-oraclelogminer]  fix UNISTR cannot parse string
@FlechazoW FlechazoW merged commit 79c02b8 into DTStack:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants