Fixed a localization fallback issue#926
Merged
david-poindexter merged 1 commit intoDNNCommunity:developfrom Feb 14, 2024
Merged
Fixed a localization fallback issue#926david-poindexter merged 1 commit intoDNNCommunity:developfrom
david-poindexter merged 1 commit intoDNNCommunity:developfrom
Conversation
Some components use localizable test. The idea implemented was to provide default and allow consumers to override them. The implementation before this PR was to merge a set of defaults with the `resx` prop. However this would only happen once (when the component loaded). So if the parent component would reload and reset the resx value, that new value would replace everything not re-runing the fallback logic. This PR makes it so localized components now watch the `resx` prop and re-run the fallback logic to store it in a private `localResx` state instead. Closes DNNCommunity#924
david-poindexter
approved these changes
Feb 14, 2024
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Nice work there @valadas 🌮
|
|
||
| /** A list of allowed file extensions. | ||
| * If not specified, any file is allowed. | ||
| * Ex: ["jpg", "jped", "gif", "png"] |
Contributor
There was a problem hiding this comment.
Oops - nice catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some components use localizable test. The idea implemented was to provide default and allow consumers to override them. The implementation before this PR was to merge a set of defaults with the
resxprop. However this would only happen once (when the component loaded). So if the parent component would reload and reset the resx value, that new value would replace everything not re-runing the fallback logic.This PR makes it so localized components now watch the
resxprop and re-run the fallback logic to store it in a privatelocalResxstate instead.Closes #924