Added a optional filesize limit for dnn-dropzone.#727
Merged
valadas merged 2 commits intoDNNCommunity:developfrom May 21, 2023
Merged
Added a optional filesize limit for dnn-dropzone.#727valadas merged 2 commits intoDNNCommunity:developfrom
valadas merged 2 commits intoDNNCommunity:developfrom
Conversation
valadas
requested changes
May 20, 2023
Member
valadas
left a comment
There was a problem hiding this comment.
Looks good, except rethinking about it now, we need to do something different for the resx (localization/language resources).
This would currently be a breaking change for any consumer using the resx prop as if they specified their own object without all the properties, then they would be missing the ones we just added.
We need to make the prop only have a type and and then merge what we got with our defaults.
I can help with that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an optional filesize limit for dnn-dropzone. Also updated rexs's values for dnn-image-cropper as it also used bits of dnn-drop-zone.
Closes #667.