Skip to content

Makes dnn-Modal resizable.#713

Merged
valadas merged 2 commits intoDNNCommunity:developfrom
Raaphe:dnn_modal_resizable
May 14, 2023
Merged

Makes dnn-Modal resizable.#713
valadas merged 2 commits intoDNNCommunity:developfrom
Raaphe:dnn_modal_resizable

Conversation

@Raaphe
Copy link
Copy Markdown
Contributor

@Raaphe Raaphe commented May 12, 2023

Makes dnn-Modal resizable.

resolves #541.

Copy link
Copy Markdown
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Raaphe , something just came to mind. Can we make the resizable behaviour "opt-in", so basically have a resizable boolean prop and we only render the se corner if that is true...

@valadas valadas added this to the 0.18.0 milestone May 12, 2023
Copy link
Copy Markdown
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@valadas valadas added the enhancement New feature or request label May 14, 2023
@valadas valadas merged commit 7118958 into DNNCommunity:develop May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dnn-modal should be resizable

2 participants