Fixed a few assets paths issues for monaco-editor#655
Merged
david-poindexter merged 2 commits intoDNNCommunity:release/0.16.0from Dec 4, 2022
Merged
Fixed a few assets paths issues for monaco-editor#655david-poindexter merged 2 commits intoDNNCommunity:release/0.16.0from
david-poindexter merged 2 commits intoDNNCommunity:release/0.16.0from
Conversation
This copies some assets needed on the page level and loads them in the page head if the editor is used on the page. The monaco css also requires a font and it is expected to live in a very specific relative path so files need to be manually copied into specific folders. It also looks like a full build was not run before the beta release, so some docs were not auto-generated on other components earlier. Also I added a new method to allow consumers to change the code content after the component is already loaded.
david-poindexter
approved these changes
Dec 4, 2022
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Awesomeness @valadas 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies some assets needed on the page level and loads them in the page head if the editor is used on the page.
The monaco css also requires a font and it is expected to live in a very specific relative path so files need to be manually copied into specific folders.
It also looks like a full build was not run before the beta release, so some docs were not auto-generated on other components earlier.
Also I added a new method to allow consumers to change the code content after the component is already loaded.