Upgrade lit-html to v2.3.1#610
Merged
david-poindexter merged 1 commit intoDNNCommunity:developfrom Sep 20, 2022
Merged
Conversation
Appears to fix a Storybook issue
david-poindexter
approved these changes
Sep 20, 2022
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Awesome - thanks @OllyHodgson
Member
|
Thanks @OllyHodgson and @david-poindexter Was this tested though, cause on my side that did not fix the issue... |
Contributor
|
I didn't test Storybook but saw on Slack that it didn't fix the issue. Nonetheless, it didn't seem to break anything else so I saw no harm in accepting the PR and getting this dependency updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appears to fix the "Expecting an HTML snippet or DOM node from the story" issue with Storybook.