Resolved collapsible nesting issues#463
Merged
valadas merged 2 commits intoDNNCommunity:release/0.14.0from Feb 20, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the collapsible component to be more simple and fixes an issue with nesting collapsible in a certain way where parents would not update their size properly if the contents of slots are dynamically changed at runtime.
The behaviour here is that it will transition to the height of the knows content but afterwards will release the fixed size and just snap to the new content should it change dynamically. We win in usability here but have a small snap UI effect in some situations. I would like to improve this one day, but for now, this makes it more usable.