Resolved multiple warnings about changing state during render#453
Merged
valadas merged 1 commit intoDNNCommunity:developmentfrom Feb 14, 2022
Merged
Conversation
A warning shows whenever a state that triggers a re-render happens as it is usually something that should be done before rendering and an extra render can be avoided by moving it to another lifecycle event. However in some cases it does make sense to re-render on purpose. The way to avoid the warning is to wrap the method in a requestAnimationFrame promise so that the state changes when we are sure the initial rendering is totally complete. It does not change much as it still re-renders but it kinda declares that it was on purpose and we know what we are doing. This way the warning goes away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A warning shows whenever a state that triggers a re-render happens as it is usually something that should be done before rendering and an extra render can be avoided by moving it to another lifecycle event. However in some cases it does make sense to re-render on purpose. The way to avoid the warning is to wrap the method in a requestAnimationFrame promise so that the state changes when we are sure the initial rendering is totally complete. It does not change much as it still re-renders but it kinda declares that it was on purpose and we know what we are doing. This way the warning goes away.