Fixed an issue that prevented cropping images on firefox#424
Merged
valadas merged 1 commit intodevelopmentfrom Jan 11, 2022
Merged
Fixed an issue that prevented cropping images on firefox#424valadas merged 1 commit intodevelopmentfrom
valadas merged 1 commit intodevelopmentfrom
Conversation
TouchEvent is not supported on firefox which caused the dragging code to fail. Also changing an image src to a data-url is not instant in firefox so had to attach a load event on it to run the logic only after the image is fully loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TouchEvent is not supported on firefox which caused the dragging code to fail. Also changing an image src to a data-url is not instant in firefox so had to attach a load event on it to run the logic only after the image is fully loaded.