Removed stencil-inline-svg due to a bug#420
Merged
valadas merged 1 commit intorelease/0.11.1from Jan 9, 2022
Merged
Conversation
Consumers of this package would have to do something special on their hand and since these components need to be universal, I do not want this situation. This PR removes the svg module and the inline-svg bundling and brings back normal svgs inline in the render method. This feature might come back if fabriciomendonca/stencil-inline-svg#5 gets resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers of this package would have to do something special on their hand and since these components need to be universal, I do not want this situation.
This PR removes the svg module and the inline-svg bundling and brings back normal svgs inline in the render method.
This feature might come back if fabriciomendonca/stencil-inline-svg#5 gets resolved.