Merged
Conversation
This changes most inline svg icons into the material icons svg npm package. This is a potential breaking change from consumers of this library as you will either end up with an inline svg or a base64 data-url depending on how this is consumed which may affect how the css works out. In theory because we are in shadow-dom, it should not be an issue but it is worth testing before upgrading to this new version. For stenciljs consumers of this package you can simply `npm install stencil-inline-svg --save-dev` and call it in your stencil config plugins, for usage in other frameworks, please open an issue with minimal usage scenario for help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes most inline svg icons into the material icons svg npm package.
This is a potential breaking change from consumers of this library as you will either end up with an inline svg or a base64 data-url depending on how this is consumed which may affect how the css works out. In theory because we are in shadow-dom, it should not be an issue but it is worth testing before upgrading to this new version.
For stenciljs consumers of this package you can simply
npm install stencil-inline-svg --save-devand call it in your stencil config plugins, for usage in other frameworks, please open an issue with minimal usage scenario for help.