Fixed an issue where dnn-select was not being properly initialized#1288
Merged
valadas merged 1 commit intoDNNCommunity:developfrom Apr 10, 2025
Merged
Fixed an issue where dnn-select was not being properly initialized#1288valadas merged 1 commit intoDNNCommunity:developfrom
valadas merged 1 commit intoDNNCommunity:developfrom
Conversation
When feeded <option> elements in the slot of dnn-select with a pre-selected item (selected = true) like when used on a form to edit something existing instead of doing something new; The underlying initialization logic was not setting the form level value upon initialization. This caused a discrepency as it would display as valid but would prevent form submission because the form was not valid. Also the form onInvalid event was not being fired making it even more confusing. This part was fixed in the dnn-button logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When feeding elements in the slot of dnn-select with a pre-selected item (selected = true) like when used on a form to edit something existing instead of doing something new; The underlying initialization logic was not setting the form level value upon initialization. This caused a discrepancy as it would display as valid but would prevent form submission because the form was not valid.
Also the form
onInvalidevent was not being fired making it even more confusing. This part was fixed in the dnn-button logic.