Skip to content

Recreated storybook with latest web-components builder (vite)#1277

Merged
david-poindexter merged 5 commits intoDNNCommunity:developfrom
valadas:storybook-revamp
Apr 9, 2025
Merged

Recreated storybook with latest web-components builder (vite)#1277
david-poindexter merged 5 commits intoDNNCommunity:developfrom
valadas:storybook-revamp

Conversation

@valadas
Copy link
Copy Markdown
Member

@valadas valadas commented Apr 9, 2025

I was having a hard time doing dependency updates for storybook and also wanted to use the newer (vite) builder that is now recommended for web-components projects.

So basically I deleted all of storybook except the stories themselves, then recreated storybook using their wizard. I then brought back our customizations to the styling and css-variables, etc.
It builds and reloads way faster.

I also removed the addons that we don't currently use:

  • Visual Tests - this can only run locally and we do the tests that we have in stencil directly
  • Chromatic - Technically we could set this up with a token and it would give us visual diffs from version to version but that is done with a cloud service. They do have a small free plan and we can setup that addon later if we wanted to, but for now I removed it since it does nothing until we do that.

@valadas valadas added the dependencies Pull requests that update a dependency file label Apr 9, 2025
@valadas valadas added this to the 0.26.1 milestone Apr 9, 2025
Copy link
Copy Markdown
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is freakin awesome! 👏🏼

@david-poindexter david-poindexter merged commit 041680d into DNNCommunity:develop Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants