Merged fixes from release/0.24.0 back into develop#1193
Merged
Conversation
In environments that would have different line-heights, the label position could be off. Closes #1171
Fixed an issue that caused label misalignement in dnn-fieldset
This was discusses in last co-coding to make sure we can support very different themes like light/dark/hi-contrast, etc.
Added some more css-variables
Closes setCustomValidity("") does not remove the red border until blur #1176
Fixed some issues to reset custom validity
Also fixes same for dnn-autocomplete. Fixed dnn-select and dnn-autocomplete should validate upon blur #1175
Fixed display of invalid on bluring dnn-select
Closes dnn-autocomplete, dropdown should show selections #1180
dnn-autocomplete, allow showing suggestions upon click
Closes dnn-textarea needs better height support and other css polishing #1178
Fixed some css issues with dnn-textarea
Fixed an issue where label would cover text in dnn-autocomplete
Changed label support for dnn-checkbox
Allows toggle to be wrapped in label
- Required now properly reports being invalid - Fixed multiple glitches to allow either picking an item or using free-text
Improved autocomplete behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged fixes from release/0.24.0 back into develop