Skip to content

test: isolate hermetic env and system service identity#14

Merged
DIZ-admin merged 2 commits into
mainfrom
fix/test-hermeticity-clean-pr13-refresh
May 18, 2026
Merged

test: isolate hermetic env and system service identity#14
DIZ-admin merged 2 commits into
mainfrom
fix/test-hermeticity-clean-pr13-refresh

Conversation

@DIZ-admin

@DIZ-admin DIZ-admin commented May 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • isolate hermetic env leaks in shared test fixture and auxiliary test
  • make gateway service tests patch system service identity explicitly
  • carry forward the missing hermes-agent noreply AUTHOR_MAP entry needed by attribution policy

Validation

  • python -m pytest tests/acp/test_registry_manifest.py tests/hermes_cli/test_gateway_service.py tests/agent/test_auxiliary_client.py -q

Supersedes #13 due to merge-base drift and conflict-heavy history on the old branch.

Summary by CodeRabbit

  • Chores

    • Updated author mapping configuration for changelog generation.

  • Tests

    • Enhanced test environment isolation by ensuring environment variables are properly reset between tests.

Review Change Stack

@DIZ-admin DIZ-admin mentioned this pull request May 18, 2026
Closed
@coderabbitai

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5c712de4-a258-45a0-a12a-40c42335bdb7

📥 Commits

Reviewing files that changed from the base of the PR and between 60d8df3 and 0f34778.

📒 Files selected for processing (3)
  • scripts/release.py
  • tests/agent/test_auxiliary_client.py
  • tests/conftest.py
📝 Walkthrough

Walkthrough

This PR updates the release tooling to recognize hermes-agent as an author and ensures the test environment properly removes the CUSTOM_BASE_URL variable to prevent environment leakage across all tests and a specific auxiliary client test.

Changes

Release and test environment updates

Layer / File(s) Summary
Author mapping for release changelog
scripts/release.py		 AUTHOR_MAP adds a mapping for hermes-agent@users.noreply.github.com → hermes-agent so the generated changelog correctly attributes commits from this account.
Test environment CUSTOM_BASE_URL cleanup
tests/conftest.py, tests/agent/test_auxiliary_client.py		 The global hermetic fixture and a specific test both unset CUSTOM_BASE_URL to prevent any externally configured base-URL override from affecting provider selection and routing during test execution.

Possibly related PRs

  • DIZ-admin/hermes-agent#12: Both PRs update tests/conftest.py to scrub CUSTOM_BASE_URL from the hermetic environment to prevent provider/runtime selection interference.
  • DIZ-admin/hermes-agent#3: Both PRs modify test hermetic environment cleanup to unset CUSTOM_BASE_URL in the autouse fixture.
  • DIZ-admin/hermes-agent#4: Both PRs update test environment cleanup to unset CUSTOM_BASE_URL and related base-URL overrides.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through configs small,
hermes-agent joins the roll—
Environment cleaned, tests run true,
No leaks to cloud the review! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objectives: isolating hermetic environment issues (in conftest.py and test_auxiliary_client.py) and adding system service identity mapping (in release.py for the hermes-agent author).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/test-hermeticity-clean-pr13-refresh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

🔎 Lint report: fix/test-hermeticity-clean-pr13-refresh vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8331 on HEAD, 8331 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4357 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@DIZ-admin DIZ-admin merged commit c5b1f92 into main May 18, 2026
17 checks passed
@DIZ-admin DIZ-admin deleted the fix/test-hermeticity-clean-pr13-refresh branch May 18, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DIZ-admin @hermes-agent