feat: Dota2 战队最新比赛结果#6005
Merged
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/diy/rsshub/6dk5j0fym |
[ci skip] [skip ci]
HenryQW
requested changes
Oct 29, 2020
| description: `At ${tournament}, ${team} ${score} ${vs_team}`, | ||
| pubDate: date_time, | ||
| link: url, | ||
| guid: date_time, |
Collaborator
There was a problem hiding this comment.
guid默认为link，没有必要赋值。设置成时间可能会导致缓存冲突。
Contributor
Author
There was a problem hiding this comment.
但link不是唯一的，而datetime可以保证是唯一的
Collaborator
There was a problem hiding this comment.
如果datetime和其他源的datetime冲突了呢？所以不接受datetime作为guid。
link不是唯一的情况下，可以用link+datetime解决。
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
完整路由地址 / Example for the proposed route(s)