Skip to content

feat: iindienova添加参数 #2420

Merged
DIYgod merged 3 commits into
DIYgod:masterfrom
kt286:patch-3
Jun 17, 2019
Merged

feat: iindienova添加参数 #2420
DIYgod merged 3 commits into
DIYgod:masterfrom
kt286:patch-3

Conversation

@kt286

@kt286 kt286 commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

Comment thread lib/router.js

// Indienova
router.get('/indienova/article', require('./routes/indienova/article'));
router.get('/indienova/:type', require('./routes/indienova/article'));

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议改为可选参数,以向下兼容 :type?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在就是向下兼容的啊 本来article应该叫news

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊哦看错了

@DIYgod DIYgod merged commit 70d885b into DIYgod:master Jun 17, 2019
@DIYgod

DIYgod commented Jun 17, 2019

Copy link
Copy Markdown
Owner

Merged, thanks!

@kt286 kt286 deleted the patch-3 branch June 18, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants