chore(deps): update dependency eslint-config-prettier to v5#2415
Merged
Conversation
DIYgod
approved these changes
Jun 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.3.0->5.0.0Release Notes
prettier/eslint-config-prettier
v5.0.0Compare Source
Removed: [react/self-closing-comp]. This rule was added in v4.1.0 not
because it conflicted with Prettier but because it was unnecessary when
using Prettier. However, in v1.18.0 [Prettier stopped converting empty
elements to self-closing elements][prettier-self-closing]. So the rule is
not unnecessary anymore.
If you use Prettier v1.17.1 or older you should be able to upgrade
eslint-config-prettier to v5.0.0 without having to do anything else.
If you use Prettier v1.18.0 or newer, you might get lint errors about for
example changing
<div></div>into<div />. You have two options:eslint --fixif you prefer to enforce self-closing elements wherepossible. This should fix all the errors.
"react/self-closing-comp": "off"to your ESLint config if you useautofix from your editor and you face the same [issue as Prettier
did][prettier-self-closing].
Changed: Node.js 6 is no longer officially supported, but v5.0.0 should
still work with it.
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.