Skip to content

Fix dnf installation, allow passing in CPU flag#65

Merged
DBezemer merged 3 commits intoDBezemer:devfrom
izzyleung:dev
Apr 16, 2024
Merged

Fix dnf installation, allow passing in CPU flag#65
DBezemer merged 3 commits intoDBezemer:devfrom
izzyleung:dev

Conversation

@izzyleung
Copy link
Copy Markdown
Contributor

@izzyleung izzyleung commented Aug 6, 2023 •
edited
Loading

  1. When running NO_SUDO=1 make on systems with dnf (like Amazon Linux 2023), running command yum install -y curl might result in the following error:
Error:
 Problem: problem with installed package curl-minimal-8.0.1-1.amzn2023.aarch64
  - package curl-minimal-8.0.1-1.amzn2023.aarch64 conflicts with curl provided by curl-7.87.0-2.amzn2023.0.2.aarch64
  - package curl-minimal-7.88.0-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-7.87.0-2.amzn2023.0.2.aarch64
  - package curl-minimal-7.87.0-2.amzn2023.0.2.aarch64 conflicts with curl provided by curl-7.87.0-2.amzn2023.0.2.aarch64
  - package curl-minimal-7.88.1-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-7.87.0-2.amzn2023.0.2.aarch64
  - conflicting requests
  - package curl-minimal-8.0.1-1.amzn2023.aarch64 conflicts with curl provided by curl-7.88.0-1.amzn2023.0.1.aarch64
  - package curl-minimal-7.88.0-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-7.88.0-1.amzn2023.0.1.aarch64
  - package curl-minimal-7.87.0-2.amzn2023.0.2.aarch64 conflicts with curl provided by curl-7.88.0-1.amzn2023.0.1.aarch64
  - package curl-minimal-7.88.1-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-7.88.0-1.amzn2023.0.1.aarch64
  - package curl-minimal-8.0.1-1.amzn2023.aarch64 conflicts with curl provided by curl-7.88.1-1.amzn2023.0.1.aarch64
  - package curl-minimal-7.88.0-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-7.88.1-1.amzn2023.0.1.aarch64
  - package curl-minimal-7.87.0-2.amzn2023.0.2.aarch64 conflicts with curl provided by curl-7.88.1-1.amzn2023.0.1.aarch64
  - package curl-minimal-7.88.1-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-7.88.1-1.amzn2023.0.1.aarch64
  - package curl-minimal-8.0.1-1.amzn2023.aarch64 conflicts with curl provided by curl-8.0.1-1.amzn2023.aarch64
  - package curl-minimal-7.88.0-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-8.0.1-1.amzn2023.aarch64
  - package curl-minimal-7.87.0-2.amzn2023.0.2.aarch64 conflicts with curl provided by curl-8.0.1-1.amzn2023.aarch64
  - package curl-minimal-7.88.1-1.amzn2023.0.1.aarch64 conflicts with curl provided by curl-8.0.1-1.amzn2023.aarch64
(try to add '--allowerasing' to command line to replace conflicting packages or '--skip-broken' to skip uninstallable packages)

Fix this issue by checking for dnf binary and pass in --allowerasing when it is detected

  1. Allow user to pass in CPU flag for building haproxy, and defaults it to generic

@DBezemer DBezemer merged commit b190c2b into DBezemer:dev Apr 16, 2024
@DBezemer
Copy link
Copy Markdown
Owner

DBezemer commented Apr 16, 2024

I would prefer not to add --allowerasing to DNF as this is a package issue on AL2023 and they should solve that themselves
Other than that it looks good, so merged and I'll remove --allowerasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@izzyleung @DBezemer