Merged
Conversation
Contributor
GElkayam
commented
Aug 2, 2022
- Avoid haproxy logs that are echoed from systemd-journal (errors getting send again as severity 6) by limiting source to UDP input
- Correct scoping to avoid unreachable code due to stop, and errors not logged to correct log
- Fix indentation
* Avoid haproxy logs that are echoed from systemd-journal (errors getting send again as severity 6) by limiting source to UDP input * Correct scoping to avoid unreachable code due to stop, and errors not logged to correct log * Fix indentation
|
Hello @DBezemer, can we get that reviewed and merged? |
Owner
|
In cases with systemd-journal re-echoing errors the condition should not be true, so I struggle to see what issue this fixes. Can you let me know how I can reproduce the issue you're seeing and I'll see if there's a more elegant solution. |
Contributor
Author
|
Hi @DBezemer ,
On my systems, I had to override anyway to send the logs to a custom folder, but wanted to contribute the fix upstream. |
Owner
|
Sorry for the delay, finally got around to testing this and will also merge into dev for build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.