Skip to content

fix: Selector.get_all_text() doesn't get all text #167#168

Merged
D4Vinci merged 5 commits intoD4Vinci:devfrom
mhillebrand:dev
Mar 8, 2026
Merged

fix: Selector.get_all_text() doesn't get all text #167#168
D4Vinci merged 5 commits intoD4Vinci:devfrom
mhillebrand:dev

Conversation

@mhillebrand
Copy link
Contributor

@mhillebrand mhillebrand commented Mar 6, 2026 •
edited
Loading

  • Selector.get_all_text() no longer ignores tail text nodes
  • Added new unit test

Proposed change

Type of change:

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Additional information

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doc-strings.

@mhillebrand mhillebrand mentioned this pull request Mar 6, 2026
Closed
@mhillebrand
Copy link
Contributor Author

mhillebrand commented Mar 8, 2026

@D4Vinci Oops. I did an unnecessary rebase, and now these workflows require approval again. My bad.

@D4Vinci
Copy link
Owner

D4Vinci commented Mar 8, 2026

Thanks for this fix and for reporting this issue. We will merge once you move the test to the correct file.

@D4Vinci D4Vinci added the Ready-to-Merge This PR is approved and ready to merge once the author addresses the raised points. label Mar 8, 2026
@D4Vinci D4Vinci mentioned this pull request Mar 8, 2026
Closed
@mhillebrand
Copy link
Contributor Author

mhillebrand commented Mar 8, 2026

Thanks for this fix and for reporting this issue. We will merge once you move the test to the correct file.

Glad to help. Thank you for the awesome library! I've moved my unit test to tests/parser/test_parser_advanced.py.

D4Vinci
D4Vinci approved these changes Mar 8, 2026
View reviewed changes
@D4Vinci D4Vinci merged commit 11bc08f into D4Vinci:dev Mar 8, 2026
5 checks passed
@D4Vinci D4Vinci mentioned this pull request Mar 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D4Vinci D4Vinci D4Vinci approved these changes

Assignees

No one assigned

Labels

Ready-to-Merge This PR is approved and ready to merge once the author addresses the raised points.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhillebrand @D4Vinci