fix: make MCP get schemas validator-safe#137
Merged
D4Vinci merged 2 commits intoD4Vinci:devfrom Feb 26, 2026
Merged
Conversation
Use JSON-object input types for cookies and basic-auth fields in get and bulk_get so strict MCP schema validators can register tools reliably. Normalize auth dictionaries to the tuple format expected by fetchers to preserve runtime behavior.
Owner
|
Looks good to me, thanks mate! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getandbulk_getby changingcookies,proxy_auth, andauthto dictionary-based schemas._NormalizeCredentialsto convert auth dictionaries into tuple credentials expected by the fetchers.Why
Some strict MCP clients reject tuple/list-based JSON schema variants generated for these fields and fail tool registration with errors like
array schema missing items. This change keeps runtime behavior while producing schemas that validate reliably across clients.Validation
python3 -m py_compile scrapling/core/ai.py1.2.10compatibility check:Invalid schema for function 'scrapling_get' ... array schema missing items.