added Buffered overloads of GetSubscriber, GetPublisher to GlobalMessagePipe#83
Merged
neuecc merged 3 commits intoCysharp:masterfrom Jun 23, 2022
Merged
added Buffered overloads of GetSubscriber, GetPublisher to GlobalMessagePipe#83neuecc merged 3 commits intoCysharp:masterfrom
neuecc merged 3 commits intoCysharp:masterfrom
Conversation
|
@AGeorgy I actually could use this, why was it closed instead of merged? |
|
@neuecc , wondering your thoughts on getting something like this merged to the main product? I'm not using a 3rd party DI system and want to use buffered messages with the GlobalMessagePipe. Thanks! |
Member
|
Yes, ok to merge. |
|
@neuecc yes please! I couldn't figure out how to do that (maybe I don't have access for that). Thank you! |
|
Just heads up it looks like this PR might be manually setting the package.json version number. I noticed git history looks like there's a GitHub Action tied to incrementing that number across all the packages? |
Member
|
For now, let's get it out with 1.7.4. |
|
Thanks for this! Greatly appreciate the quick turnaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.