Fixed type fetching in the part passed to MessagePack.#73
Merged
neuecc merged 1 commit intoCysharp:masterfrom Feb 1, 2022
Merged
Fixed type fetching in the part passed to MessagePack.#73neuecc merged 1 commit intoCysharp:masterfrom
neuecc merged 1 commit intoCysharp:masterfrom
Conversation
Member
|
ありがとうございます! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type fetching in the part passed to MessagePack.
IRemoteRequestHandler with multiple
IAsyncRequestHandlerinterfaces was throwing a deserialization exception when called over TCP or a named pipe. The cause seems to be the assumption that there is only oneIAsyncRequestHandler.↓ Specifically, the following way of having the interface was supported.
Sorry if I'm using the wrong premise in the first place.
This is my first pull request. Please approve it.
MessagePipe is a very powerful library, and I am using it effectively. I'm looking forward to the future development of this library.
MessagePackに渡す部分の型取得修正
IRemoteRequestHandlerにてTCPまたは名前付きパイプで呼び出すと、
複数の
IAsyncRequestHandlerインターフェイスを持つクラスにてデシリアライズ例外が発生しました。原因は
IAsyncRequestHandlerを一つしか持たない前提の処理になっていたようです。↓具体的には以下のようなインターフェイスの持ち方に対応しました。
そもそも前提の使い方を間違えていたらごめんなさい。
初めてのプルリクエストです。
フォーマットや内容など至らぬ点ございますが、
承認よろしくお願いいたします。
MessagePipe非常に強力なライブラリで有効活用させていただいております。
これからもこのライブラリの発展に期待しております。