Skip to content

feat: bom.vulnerabilities data models and enums#419

Merged
jkowalleck merged 46 commits intomainfrom
thepwagner_model-bom-vulnerabilities
Feb 2, 2023
Merged

feat: bom.vulnerabilities data models and enums#419
jkowalleck merged 46 commits intomainfrom
thepwagner_model-bom-vulnerabilities

Conversation

@jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jan 20, 2023 •
edited
Loading

Add Vulnerabilties to the BOM model, including ENUMs as needed.

new models & ENUMs are marked as @beta - they are ready for usage and feedback, but might change without further notice.

this is part of #164

checklist:

  • pull contributed models from bom.vulnerabilities model #163
  • update branch - merge in latest master
  • get the coding styles applied
  • fix various compile errors
  • remove all those compare() methods from the contributed models. it has no effect, unless it comes to reproducible normalization.
  • review contributed models & ENUMs for plausibility, schema compliance JSON/XML, etc
  • sort out if we have a problem here: [BUG] VulnerabilityReference contradicting definition in JSON and XML specification#154
  • fix contributed ENUMs
    • design: move new ENUMs in an own namespace and strip this prefix
    • if needed: add docs/comments to ENUMs based on schema annotations
  • fix contributed models
    • design: move models in an own namespace and strip this prefix
    • rename those OptionalProperties interfaces to purpose and have them exported - according to latest API architecture
    • if needed: add docs/comments to interfaces, type, classes and properties - based on schema annotations
    • all repositories default to an instance - they must not be nullable
    • find the usage of contributed VulnerabilityAffectsVersion
    • find the usage of contributed VulnerabilityAffectsRange
  • review contributed tests
  • have working and running functional tests for the ENUMs
  • have working and running REASONABLE tests for the models
  • mark all new ENUMs and models as @beta
  • write HISTOY
  • update REAMDE - annotate models that are not yet normalizable.
  • 🏁 merge

@thepwagner
Bom.Vulnerabilities model
542767b 
Signed-off-by: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
@thepwagner
rename enums per JSON schema
9d48635 
Signed-off-by: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
@thepwagner
models: Vulnerability comparisons
1221c43 
Signed-off-by: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
@thepwagner
Functional tests for vulnerability enums
9e9ff63 
Signed-off-by: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
@thepwagner
Merge remote-tracking branch 'upstream/main' into model-bom-vulnerabi…
30be7c6 
…lities
@jkowalleck jkowalleck added the enhancement New feature or request label Jan 20, 2023
This was referenced Jan 20, 2023
Closed
Closed
jkowalleck
jkowalleck commented Jan 20, 2023
View reviewed changes
@jkowalleck jkowalleck self-assigned this Jan 20, 2023
@jkowalleck jkowalleck added this to the Bom.Vulnerabilities milestone Jan 20, 2023
@jkowalleck
Merge remote-tracking branch 'origin/main' into thepwagner_model-bom-…
64aa9f4 
…vulnerabilities
@jkowalleck
test understore detection in test hepler: `stringFunctions.upperCamel…
2a4b88f 
…Case()`

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/main' into thepwagner_model-bom-…
0bad709 
…vulnerabilities
@jkowalleck
adjusted imports and inheritance to latest standards
bae282a 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/main' into thepwagner_model-bom-…
46c6cee 
…vulnerabilities
@jkowalleck
code style
ecff40f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/main' into thepwagner_model-bom-…
2fca8b9 
…vulnerabilities
@jkowalleck
Merge remote-tracking branch 'origin/main' into thepwagner_model-bom-…
399850b 
…vulnerabilities
@jkowalleck
fix compares
8bd515b 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
jkowalleck commented Jan 24, 2023
View reviewed changes
@jkowalleck jkowalleck changed the base branch from main to feature/vulnerabilities January 24, 2023 08:38
@jkowalleck jkowalleck changed the title feat: bom.vulnerabilities data models feat: bom.vulnerabilities data models and enums Jan 24, 2023
@jkowalleck
history
20a1679 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the thepwagner_model-bom-vulnerabilities branch from 410a614 to 20a1679 Compare January 24, 2023 12:29
@jkowalleck
fix VulnerabilityAffects according to spec
877d012 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs: type CPE
463eaee 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
prove reading, fixes, design&achitecture adoptions
378298d 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
apply coding standards
a250140 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
tests: fix enum tests for vulnerabilities
53c3ca9 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
tests: fixed BOM test
fe12916 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
tmp skip tests for Vulnerability models
4a4f3cf 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
optionals are aoptional
d869b18 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
tests: Models.Vulnerability.Vulnerability
8ac4dae 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
README
262a12d 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review January 31, 2023 16:28
@jkowalleck jkowalleck requested a review from a team as a code owner January 31, 2023 16:28
@jkowalleck
Merge branch 'main' into thepwagner_model-bom-vulnerabilities
270c994
@jkowalleck
HISTORY
a104945 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the thepwagner_model-bom-vulnerabilities branch from 76b49fd to a104945 Compare January 31, 2023 17:02
@jkowalleck jkowalleck changed the base branch from feature/vulnerabilities to main January 31, 2023 17:21
@jkowalleck
Merge remote-tracking branch 'origin/main' into thepwagner_model-bom-…
ba95a1a 
…vulnerabilities
@jkowalleck
mark all as beta
7f610d3 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
add private remarks for Vulnerability.Reference
068aa5a 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
beta note
a2e0eda 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
HISTORY
e81a200 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
jkowalleck commented Feb 1, 2023
View reviewed changes
@jkowalleck
docs: some light fixes
5cac6d3 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
simplified OrganizationalEntity.compare
eb304b5 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
OrganizationalEntityRepository becomes pubic API
1792433 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
announce new CWE functionality in beta state
19014fb 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the thepwagner_model-bom-vulnerabilities branch from 157c7dc to 19014fb Compare February 1, 2023 14:48
@jkowalleck jkowalleck merged commit 249ef31 into main Feb 2, 2023
@jkowalleck jkowalleck deleted the thepwagner_model-bom-vulnerabilities branch February 2, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jkowalleck jkowalleck

Labels

enhancement New feature or request

Projects

None yet

Milestone

Vulnerabilities - models, normalize, ...

Development

Successfully merging this pull request may close these issues.

2 participants

@jkowalleck @thepwagner