feat: Factories.FromNodePackageJson.PackageUrlFactory to omits PURL's npm defaults#207
Merged
jkowalleck merged 1 commit intomainfrom Sep 7, 2022
Merged
Conversation
b90eeb0 to
e031689
Compare
Closed
bdff14e to
737bdf5
Compare
Factories.FromNodePackageJson to strip purl npm defaultsFactories.FromNodePackageJson.PackageUrlFactory to strip PURL's npm defaults
Factories.FromNodePackageJson.PackageUrlFactory to strip PURL's npm defaultsFactories.FromNodePackageJson.PackageUrlFactory to omits PURL's npm defaults
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
737bdf5 to
254b466
Compare
Member
Author
|
hey @mwing , i am planning to incorporte this solution into https://github.com/CycloneDX/cyclonedx-node-npm This means, that there will be no need to a switch, the PURLS would be shorter out of the box, unless additional qualifiers are needed to identify a component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Factories.FromNodePackageJson.PackageUrlFactorythat acts likeFactories.PackageUrlFactory, butomits PackageUrl's npm-specific "default derived" qualifier values for
download_url&vcs_url.fixes #204