feat!: give downstream users control over optional dependencies#1295
Merged
jkowalleck merged 12 commits intoCycloneDX:mainfrom Sep 15, 2025
Merged
feat!: give downstream users control over optional dependencies#1295jkowalleck merged 12 commits intoCycloneDX:mainfrom
jkowalleck merged 12 commits intoCycloneDX:mainfrom
Conversation
7a7ea8e to
95c9871
Compare
jkowalleck
requested changes
Sep 12, 2025
Member
jkowalleck
left a comment
There was a problem hiding this comment.
so much unintended change.
please revert everything that is not needed for this feature
jkowalleck
requested changes
Sep 12, 2025
Signed-off-by: Gautier Ben Aïm <benaim.gautier@gmail.com>
95c9871 to
5cc5554
Compare
Contributor
Author
|
Sorry for the noise, I completely botched the PR 😬 |
jkowalleck
approved these changes
Sep 12, 2025
Member
|
thanks a lot for this feature. |
Member
added some docs for the topic: #1296 |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Member
|
this feature was released via https://github.com/CycloneDX/cyclonedx-javascript-library/releases/tag/v9.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Closes #1294
Setfilesto remove config and source files from npmSetsideEffects: falseto improve tree shakingI did these changes out of habit, if they are wrong/not desired I'll revert them
You might want to run
npx sort-package-jsonto keep all the fields in a consistent order, but that's a big diff, I did not do it