Fixing tipi-build / Build as dependency CI step#760
Merged
Cyan4973 merged 1 commit intoCyan4973:devfrom Nov 10, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #759 the way tipi synchronizes sources locally during build creates an issue the the case of relative includes that lead to paths outside of the build working directory structure.
Previously the in-place build tipi was running could resolve the path which could have masked issues with the dependency build.
As I think that knowing that xxHash can be depended upon in tipi projects is valuable here's a fix that patches the relative
#include-s up during the build step.