Skip to content

feat(1/N): add support of block replication#218

Merged
bigbigxu merged 23 commits intoCurvineIO:mainfrom
zuston:replication
Aug 27, 2025
Merged

feat(1/N): add support of block replication#218
bigbigxu merged 23 commits intoCurvineIO:mainfrom
zuston:replication

Conversation

@zuston
Copy link
Copy Markdown
Contributor

@zuston zuston commented Aug 21, 2025

No description provided.

@zuston zuston marked this pull request as draft August 21, 2025 08:26
@zuston zuston changed the title feat: add support of block replication detection and completion feat(1/N): add support of block replication detection and completion Aug 21, 2025
@zuston
Copy link
Copy Markdown
Contributor Author

zuston commented Aug 21, 2025

This is a major feature. I will keep the development progress open in this PR for reviewers. cc @bigbigxu

@bigbigxu
Copy link
Copy Markdown
Contributor

This is a major feature. I will keep the development progress open in this PR for reviewers. cc @bigbigxu

Fix the Clippy check errors. You can use the following command to check and attempt to fix them:

cargo clippy --release --fix  --allow-dirty --allow-staged --allow-no-vcs -- --deny warnings --allow clippy::uninlined-format-args

Some errors may need to be fixed manually.

@zuston
Copy link
Copy Markdown
Contributor Author

zuston commented Aug 21, 2025

cargo clippy --release --fix --allow-dirty --allow-staged --allow-no-vcs -- --deny warnings --allow clippy::uninlined-format-args

Got it

@bigbigxu
Copy link
Copy Markdown
Contributor

@zuston
Copy link
Copy Markdown
Contributor Author

zuston commented Aug 21, 2025

There are still errors: https://github.com/CurvineIO/curvine/actions/runs/17123516579/job/48569767112?pr=218

Yes. After all ready, I will fix

}
}

impl From<WorkerAddress> for WorkerAddressProto {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the functions of ProtoUtils to handle address conversion.
Strictly speaking, Proto data structures should only appear in one place and should not be used elsewhere.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bigbigxu
Copy link
Copy Markdown
Contributor

https://github.com/CurvineIO/curvine/actions/runs/17155398523/job/48671053068
When encountering Clippy inspection errors, if certain methods or variables are intended for future use, you can temporarily disable the check by adding #![allow(unused)]at the file or mod.rs

@zuston
Copy link
Copy Markdown
Contributor Author

zuston commented Aug 25, 2025

How about adding then end-to-end test by using the MiniCluster ? @bigbigxu

@zuston zuston changed the title feat(1/N): add support of block replication detection and completion feat(1/N): add support of block replication Aug 26, 2025
@zuston zuston marked this pull request as ready for review August 26, 2025 09:37
@bigbigxu bigbigxu merged commit f096e36 into CurvineIO:main Aug 27, 2025
3 checks passed
@lzjqsdd lzjqsdd added the enhancement New feature or request label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants