This repository was archived by the owner on Nov 9, 2019. It is now read-only.
Add a testcase for fd_filestat_set_*#56
Merged
kubkon merged 2 commits intoCraneStation:masterfrom Aug 9, 2019
Merged
Conversation
This PR matches CraneStation/wasi-misc-tests#14. The file was created using `cargo build --release --target=wasm32-wasi`
…mes, which is not implemented yet
kubkon
reviewed
Aug 9, 2019
| "symlink_loop" => true, | ||
| "clock_time_get" => true, | ||
| "truncation_rights" => true, | ||
| "fd_filestat_set" => true, |
Member
Member
I'd personally submit the testcase as part of the PR which introduces a new feature, so in this case, #54. But this way is good provided we merge #54 first and we don't exclude the test from Windows build ;-) |
Member
Author
Member
|
Ah, that's an excellent point actually the results of which we have witnessed first hand in bytecodealliance/wasmtime#255 ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR matches CraneStation/wasi-misc-tests#14 and should be merged before #54.
The file was created using
cargo build --release --target=wasm32-wasi(I'm not really sure how I should submit the .wasm files)