This repository was archived by the owner on Nov 9, 2019. It is now read-only.
Move common functionality into hostcalls mod#26
Merged
sunfishcode merged 1 commit intoCraneStation:masterfrom Jun 18, 2019
kubkon:common-refactor
Merged
Move common functionality into hostcalls mod#26sunfishcode merged 1 commit intoCraneStation:masterfrom kubkon:common-refactor
sunfishcode merged 1 commit intoCraneStation:masterfrom
kubkon:common-refactor
Conversation
This was referenced Jun 11, 2019
Merged
Member
|
This looks great! It is likely that as WASI grows, we'll have even more code in common between the platforms, so this is a good direction to head in. |
Member
Author
Agreed! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is essentially a housekeeping change. It strives to refactor out as much of common functionality between *nix and other hosts such as Windows as possible.
To provide some context, this PR came about as a direct result of my discussion with @sunfishcode (see #22) that it would be nice to re-use as much of common stuff as possible especially since WASI is still rather volatile and certain things which might be common between different hosts might change in the near future.
Quick summary of changes:
hostcallswhich is located directly in the root of the crate: