This repository was archived by the owner on Nov 9, 2019. It is now read-only.
Refactor poll_oneoff on Unix for easier implementation on Windows.#140
Closed
marmistrz wants to merge 1 commit intoCraneStation:masterfrom
Closed
Refactor poll_oneoff on Unix for easier implementation on Windows.#140marmistrz wants to merge 1 commit intoCraneStation:masterfrom
marmistrz wants to merge 1 commit intoCraneStation:masterfrom
Conversation
e3d96e2 to
80cec8a
Compare
Member
|
@marmistrz could you put the refactoring bit on hold until #137 lands? I envision some major changes to come out of that and wouldn't want you to spend too much time on refactoring potentially dead code. |
Member
Author
Member
Member
Author
|
Closing in favor of #137. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to merge it before we land any kind of socket-related code. The absence of non-regular files on Windows makes it much easier to implement
poll_oneoffon Windows.Tasks:
poll_oneoffon Windows.