Merged
Conversation
Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #658 +/- ##
===============================================
- Coverage 88.86% 88.66% -0.20%
===============================================
Files 222 224 +2
Lines 12533 12605 +72
===============================================
+ Hits 11137 11176 +39
- Misses 1396 1429 +33
|
- Fixed compiler error Signed-off-by: The MathWorks, Inc. <alchrist@mathworks.com>
carneyweb
previously requested changes
Jul 10, 2023
jeffdiclemente
requested changes
Mar 1, 2024
Member
jeffdiclemente
left a comment
There was a problem hiding this comment.
is the third_party/boost/nowide update necessary for this change?
|
Is this feature ready? |
Contributor
@jeffdiclemente I don't think so. I am not sure how those got into the changelist |
Member
not yet. what we have in this PR is the service interface. The implementation of the interface still needs to be done. |
jeffdiclemente
approved these changes
Apr 2, 2024
Everything was resolved. Not sure of why this is still blocking merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the EventAdmin interface (locally called EM). It follows the OSGi specification for EventAdmin: https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.event.html
Testing Information
Tests have been added to the
compendium/EMdirectory. These tests cover functionality provided by the implementation ofEMEvent.