Skip to content

Refactor async deadlock prevention#1027

Merged
tcormackMW merged 2 commits intodevelopmentfrom
updateCompManagerAsyncHandling
Aug 8, 2024
Merged

Refactor async deadlock prevention#1027
tcormackMW merged 2 commits intodevelopmentfrom
updateCompManagerAsyncHandling

Conversation

@tcormackMW
Copy link
Copy Markdown
Contributor

No description provided.

@tcormackMW tcormackMW self-assigned this Jul 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.34%. Comparing base (aebd9f8) to head (007f1ba).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1027      +/-   ##
===============================================
+ Coverage        88.31%   88.34%   +0.02%     
===============================================
  Files              247      248       +1     
  Lines            11938    11924      -14     
===============================================
- Hits             10543    10534       -9     
+ Misses            1395     1390       -5     
Files Coverage Δ
...ium/DeclarativeServices/src/SCRBundleExtension.cpp 96.72% <100.00%> (ø)
...anager/BundleOrPrototypeComponentConfiguration.cpp 80.34% <100.00%> (ø)
...clarativeServices/src/manager/ComponentManager.hpp 100.00% <ø> (ø)
...ativeServices/src/manager/ComponentManagerImpl.cpp 95.96% <100.00%> (+1.88%) ⬆️
...ativeServices/src/manager/ComponentManagerImpl.hpp 100.00% <ø> (ø)
...es/src/manager/SingletonComponentConfiguration.cpp 89.90% <100.00%> (ø)
...iveServices/src/manager/states/CMDisabledState.cpp 100.00% <100.00%> (ø)
...iveServices/src/manager/states/CMDisabledState.hpp 100.00% <ø> (ø)
...tiveServices/src/manager/states/CMEnabledState.cpp 86.48% <100.00%> (ø)
...tiveServices/src/manager/states/CMEnabledState.hpp 100.00% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
Comment thread compendium/DeclarativeServices/test/gtest/TestComponentRegistry.cpp
@tcormackMW tcormackMW merged commit dba980a into development Aug 8, 2024
@tcormackMW tcormackMW deleted the updateCompManagerAsyncHandling branch August 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants