Release Lock Sooner in SCRRegistryExtension::Remove and Clear#1008
Merged
tcormackMW merged 2 commits intodevelopmentfrom May 28, 2024
Merged
Release Lock Sooner in SCRRegistryExtension::Remove and Clear#1008tcormackMW merged 2 commits intodevelopmentfrom
tcormackMW merged 2 commits intodevelopmentfrom
Conversation
Contributor
|
No warnings, LGTM! |
jeffdiclemente
approved these changes
May 28, 2024
Member
jeffdiclemente
left a comment
There was a problem hiding this comment.
while you're in this area of the code, please fix #include <map> in SCRExtensionRegistry.hpp to #include <unordered_map>
Contributor
|
No warnings, LGTM! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1008 +/- ##
===============================================
+ Coverage 83.48% 88.91% +5.42%
===============================================
Files 127 240 +113
Lines 5207 11670 +6463
===============================================
+ Hits 4347 10376 +6029
- Misses 860 1294 +434
|
Contributor
|
Thanks for sorting this so quickly! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.