Fix RemoveFromBoundServicesCache to handle invalid service objects#1007
Merged
tcormackMW merged 1 commit intodevelopmentfrom May 1, 2024
Merged
Fix RemoveFromBoundServicesCache to handle invalid service objects#1007tcormackMW merged 1 commit intodevelopmentfrom
tcormackMW merged 1 commit intodevelopmentfrom
Conversation
Contributor
|
No warnings, LGTM! |
jeffdiclemente
approved these changes
Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1007 +/- ##
===============================================
- Coverage 88.06% 79.31% -8.76%
===============================================
Files 259 124 -135
Lines 13558 5013 -8545
===============================================
- Hits 11940 3976 -7964
+ Misses 1618 1037 -581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an invalid ServiceObject is returned from
bc.GetServiceObjects, calling GetService will return an invalid service. If we see this, we should not continue to removeFromBoundServicesCache.