-
Notifications
You must be signed in to change notification settings - Fork 286
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: CppMicroServices/CppMicroServices
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.8.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: CppMicroServices/CppMicroServices
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.8.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 56 files changed
- 5 contributors
Commits on Feb 29, 2024
-
Add dynamic targeting functionality for factory services to DS. (#977)
* Add dynamic targeting functionality for factory services to DS. Add dynamic targeting functionality for factory services to DS. - move CreateFactoryComponent from ConfigurationNotifier to new class ComponentFactoryImpl - Process targets from configuration objects in CreateFactoryComponent - Add one test. (more to be added later). Signed-off by: pelliott@mathworks.com * Update TestSCRExtensionRegistry.cpp Fix merge issue. Signed-off-by: pelliott@mathworks.com * Update ComponentFactoryImpl.cpp Fixed local variable with no name issue. Signed-off-by: pelliott@mathworks.com * Changes requested by code reviews Changes from code reviews to improve efficiency. Signed-off-by: pelliott@mathworks.com * Added tests for the dynamic target functionality Added more tests for the factory dynamic target functionality. Signed-off by: The MathWorks Inc. <pelliott@mathworks.com> * Update ConfigurationNotifier.cpp Fixed compiler error on mac os caused by initializing memory variables out of order. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Fix data race condition detected by Thread Sanitizer Added mutex to be used by CreateFactoryConfiguration when calculating the random instance name for the factory pid. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Update TestFactoryTarget.cpp Fix memory leak in usDeclarativeServicesTests. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * dynamic target for factory services Made some fixes as a result of code review feedback. Also added tests to improve code coverage. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Fixed issues from code review of dynamic target functionality Fixed issues in ComponentFactoryImpl.cpp and TestFactoryTarget.cpp. Code review feedback. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Added tests for dynamic targets Dynamic targets only apply to configuration objects associated with constructing factory instances. Added code to detect and log dynamic targets in configuration objects that are not constructing factory instances. Added tests to confirm logging and to confirm that the appearance of a dynamic target in a configuration object that is not constructing a factory instance has no effect. Signed-off-by. The MathWorks, Inc. <pelliott@mathworks.com> * SCRCodeGen change for factory components Added test to make sure that the configuration-pid array for factory components only contains one pid. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Changes do to code review feedback for dynamic target implementation Changes from code review feedback. The most significant ones were: ConfigurationAdminImpl::RandomInstanceName - replaced mutex by using thread_local storage for the variable. When a dynamic target appears in a configuration object the key will be referenceName.target instead of interfaceName. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Responses to code review feedback Fixed issues raised by code reviews. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Responses to code review feedback Update dynamic target functionality based on code review feedback. Signed-off-by: The Mathworks, Inc. <pelliott@mathworks.com> * Update ComponentFactoryImpl.cpp Fixed problem introduced in last commit. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Update ConfigurationAdminImpl.hpp Whitespace change. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * TestBundleDSFAC1 fix Fix unused input parameter error. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Update TestFixture.hpp Removing these reset function calls introduced some memcheck issues. Restoring the calls. Signed-off-by: The MathWorks, Inc. <pelliott@mathworks.com> * Update ConfigurationNotifier.hpp FIx merge issue * Update ConfigurationNotifier.hpp Fix merge issue * Update compendium/DeclarativeServices/src/manager/ComponentFactoryImpl.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compendium/DeclarativeServices/src/manager/ComponentFactoryImpl.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compendium/DeclarativeServices/src/manager/ComponentFactoryImpl.hpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compendium/DeclarativeServices/src/manager/ComponentFactoryImpl.hpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compendium/test_bundles/TestBundleDSFAC1/src/ServiceImpl.hpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update compendium/DeclarativeServices/src/manager/ComponentFactoryImpl.hpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Get rid of some clang tidy warnings Signed-off-by The MathWorks, Inc. <pelliott#mathworks.com> * Update ServiceImpl.hpp Updating link tidy warnings. <pelliott@mathworks.com> * Fixed errors introduced by clang tidy fixes. Fixed errors introduced by clang tidy fixes.Signed-off-by <pelliott@mathworks.com> * Update ComponentFactoryImpl.cpp Fix issues introduced by clang tidy edits. signed-off-by The MathWorks, Inc. <pelliott@mathworks.com> * Update ComponentFactoryImpl.cpp Fiz ComponentFactoryImpl Constructor issue introduced by clang tidy "fixes". Signed-off-by The MathWorks, Inc. <pelliott@mathworks.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1Configuration menu - View commit details
-
Copy full SHA for 5f144ee - Browse repository at this point
Copy the full SHA 5f144eeView commit details
Commits on Mar 6, 2024
-
Update versioning and changelog (#1002)
Update versioning for release 3.8.2 and Release notes
1Configuration menu - View commit details
-
Copy full SHA for e6c144d - Browse repository at this point
Copy the full SHA e6c144dView commit details
Commits on Mar 11, 2024
-
Fixed clang-tidy warnings (#1003)
Fix warnings related to the [bugprone-reserved-identifier] rule Signed-off-by: The MathWorks, Inc. <jdicleme@mathworks.com>
1Configuration menu - View commit details
-
Copy full SHA for 63c8cc1 - Browse repository at this point
Copy the full SHA 63c8cc1View commit details
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d78fc0b - Browse repository at this point
Copy the full SHA d78fc0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8191bc - Browse repository at this point
Copy the full SHA e8191bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f735a5 - Browse repository at this point
Copy the full SHA 7f735a5View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.8.2...v3.8.3