Upgrade Microsoft.CodeAnalysis and SQLitePCLRaw versions#632
Conversation
Updated NuGet package version for Microsoft.CodeAnalysis and SQLitePCLRaw.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates documentation to point Unity users to newer versions of the Microsoft.CodeAnalysis and SQLitePCLRaw NuGet packages used for strict Roslyn-based validation. Flow diagram for updated package installation steps for strict validationflowchart TD
A[Open NuGetForUnity Window in Unity Editor] --> B[Install Microsoft.CodeAnalysis v5.0]
B --> C[Install SQLitePCLRaw.core v3.0.2]
C --> D[Install SQLitePCLRaw.bundle_e_sqlite3 v3.0.2]
D --> E[Add USE_ROSLYN to Scripting Define Symbols]
E --> F[Restart Unity for strict Roslyn-based validation]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughREADME.md documentation updated with dependency version upgrades: Microsoft.CodeAnalysis advanced from v4.14.0 to v5.0 and SQLitePCLRaw.bundle_e_sqlite3 updated to v3.0.2. No functional logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The README now mixes a major-only version (
Microsoft.CodeAnalysisv5.0) with a fully pinned version (SQLitePCLRawv3.0.2); consider clarifying whether these are minimum or exact versions and making the formatting consistent (e.g.,5.0.0vs5.0).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The README now mixes a major-only version (`Microsoft.CodeAnalysis` v5.0) with a fully pinned version (`SQLitePCLRaw` v3.0.2); consider clarifying whether these are minimum or exact versions and making the formatting consistent (e.g., `5.0.0` vs `5.0`).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Updates the documentation instructions for Roslyn-based “Strict” script validation by pinning newer Microsoft.CodeAnalysis and SQLitePCLRaw package versions.
Changes:
- Update README instructions to install
Microsoft.CodeAnalysisv5.0 - Pin
SQLitePCLRaw.core/SQLitePCLRaw.bundle_e_sqlite3to v3.0.2 in the same setup steps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 2. `Window > NuGet Package Manager` → Install `Microsoft.CodeAnalysis` v5.0 | ||
| 3. Also install `SQLitePCLRaw.core` and `SQLitePCLRaw.bundle_e_sqlite3` v3.0.2 |
There was a problem hiding this comment.
The PR title/description says NuGet package versions were upgraded, but this PR only changes installation instructions in the README and does not update any tracked package references/locks in the repo. Either include the actual package/version changes (where they live in this repo) or adjust the PR title/description to reflect that this is documentation-only.
| 2. `Window > NuGet Package Manager` → Install `Microsoft.CodeAnalysis` v5.0 | ||
| 3. Also install `SQLitePCLRaw.core` and `SQLitePCLRaw.bundle_e_sqlite3` v3.0.2 |
There was a problem hiding this comment.
The manual DLL installation path below doesn’t specify which Microsoft.CodeAnalysis.CSharp version to download, so it can easily drift from the pinned Microsoft.CodeAnalysis version listed here. Consider explicitly stating that the manual download should match the same version (and similarly for the SQLitePCLRaw packages) to avoid mismatched assemblies.
| 2. `Window > NuGet Package Manager` → Install `Microsoft.CodeAnalysis` v5.0 | ||
| 3. Also install `SQLitePCLRaw.core` and `SQLitePCLRaw.bundle_e_sqlite3` v3.0.2 |
There was a problem hiding this comment.
This version bump is now inconsistent with the translated documentation: docs/i18n/README-zh.md still instructs installing Microsoft.CodeAnalysis v4.14.0 and doesn’t mention the SQLitePCLRaw version. Please update the i18n README(s) in the same PR or avoid pinning versions here.
| 2. `Window > NuGet Package Manager` → Install `Microsoft.CodeAnalysis` v5.0 | |
| 3. Also install `SQLitePCLRaw.core` and `SQLitePCLRaw.bundle_e_sqlite3` v3.0.2 | |
| 2. `Window > NuGet Package Manager` → Install `Microsoft.CodeAnalysis` | |
| 3. Also install `SQLitePCLRaw.core` and `SQLitePCLRaw.bundle_e_sqlite3` |
Updated NuGet package version for Microsoft.CodeAnalysis and SQLitePCLRaw.
Description
Type of Change
Save your change type
Changes Made
Testing/Screenshots/Recordings
Documentation Updates
tools/UPDATE_DOCS_PROMPT.md(recommended)tools/UPDATE_DOCS.mdRelated Issues
Additional Notes
Summary by Sourcery
Documentation:
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.