Update URL for v9#537
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the default backend base URL used for Unity Asset Store releases to a new version-specific endpoint for v9, ensuring older versions keep working against their existing URLs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughA default base URL constant in the Asset Store release preparation script was updated from an HTTP localhost endpoint to an HTTPS hosted endpoint with a trailing slash, modifying the default remote URL behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this URL will change with each major version, consider centralizing it in a small config or versioned constant so you don't need to touch the script code every time and can avoid hard-coded, hash-like hostnames here.
- The new URL includes a trailing slash while the previous one did not; double-check that callers that concatenate paths to
DefaultBaseUrlwon't produce double slashes or rely on the absence of a trailing slash.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this URL will change with each major version, consider centralizing it in a small config or versioned constant so you don't need to touch the script code every time and can avoid hard-coded, hash-like hostnames here.
- The new URL includes a trailing slash while the previous one did not; double-check that callers that concatenate paths to `DefaultBaseUrl` won't produce double slashes or rely on the absence of a trailing slash.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll change the URL every major version change so things don't break for users on old versions on the Asset Store
Summary by Sourcery
Enhancements:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.