Skip to content

feat: Mark setup as completed when user clicks Done button#529

Merged
msanatan merged 1 commit into
CoplayDev:mainfrom
msanatan:fix-setup-window-popup
Jan 7, 2026
Merged

feat: Mark setup as completed when user clicks Done button#529
msanatan merged 1 commit into
CoplayDev:mainfrom
msanatan:fix-setup-window-popup

Conversation

@msanatan

@msanatan msanatan commented Jan 7, 2026

Copy link
Copy Markdown
Member

Closes #523

Summary by Sourcery

New Features:

  • Record setup completion via SetupWindowService when the Done button is clicked in the MCP setup window.

@msanatan msanatan self-assigned this Jan 7, 2026
@coderabbitai

coderabbitai Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@msanatan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5e21f12 and 8b43638.

📒 Files selected for processing (1)
  • MCPForUnity/Editor/Windows/MCPSetupWindow.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai

sourcery-ai Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Marks the setup process as completed when the user clicks the Done button in the MCP setup window, by invoking the setup window service before closing the window.

Sequence diagram for marking setup as completed on Done click

sequenceDiagram
    actor User
    participant MCPSetupWindow
    participant SetupWindowService

    User->>MCPSetupWindow: Click Done button
    MCPSetupWindow->>SetupWindowService: MarkSetupCompleted()
    SetupWindowService-->>MCPSetupWindow: Setup marked as completed
    MCPSetupWindow->>MCPSetupWindow: Close()
Loading

File-Level Changes

Change Details Files
Trigger setup completion via the setup service when the Done button is clicked in the MCP setup window.
  • Invoke the SetupWindowService.MarkSetupCompleted method inside OnDoneClicked before closing the window
  • Ensure that clicking Done both records completion state and closes the setup window
MCPForUnity/Editor/Windows/MCPSetupWindow.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#523 Persist setup completion state when the user clicks the "Done" button in the MCP setup window so that the completion flag is saved to EditorPrefs.
#523 Prevent the MCP setup dialog from reappearing on subsequent Unity launches after setup has been completed once.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@msanatan msanatan merged commit 34b6a11 into CoplayDev:main Jan 7, 2026
2 checks passed
@msanatan msanatan deleted the fix-setup-window-popup branch January 7, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup dialog appears on every Unity startup despite completion (since PR #375)

1 participant