MCPForUnity/Editor/Windows/Components/Settings/McpSettingsSection.uxml (1)

38-38: Consider UX clarity for the browse button.

The button labeled "Select" opens a folder panel (per the CS implementation), but the field label "Server Path/URL:" and placeholder text suggest that both local paths and Git URLs (e.g., git+https://...) are valid inputs. Users wanting to specify a Git URL must manually type it rather than browse. This is functional but may cause brief confusion.

Consider either:

• Renaming the button to "Browse Local..." to clarify it's for local paths only, or
• Adding a help tooltip to the button indicating it's for local folder selection

MCPForUnity/Editor/Windows/Components/Settings/McpSettingsSection.cs (1)

276-287: Remove redundant EditorPrefs update and event invocations.

Lines 282-284 duplicate work already performed by the RegisterValueChangedCallback on Lines 131-144. When gitUrlOverride.value is set on Line 281, the callback automatically:

• Updates EditorPrefs
• Invokes OnGitUrlChanged
• Invokes OnHttpServerCommandUpdateRequested

Then Lines 282-284 repeat these operations, causing events to fire twice.

Note: The clearGitUrlButton handler (Lines 146-152) has the same redundancy pattern, so this is consistent with existing code. However, both handlers should be fixed for correctness and efficiency.

Apply this diff to remove redundancy:

 private void OnBrowseGitUrlClicked()
 {
     string picked = EditorUtility.OpenFolderPanel("Select Server folder", string.Empty, string.Empty);
     if (!string.IsNullOrEmpty(picked))
     {
         gitUrlOverride.value = picked;
-        EditorPrefs.SetString(EditorPrefKeys.GitUrlOverride, picked);
-        OnGitUrlChanged?.Invoke();
-        OnHttpServerCommandUpdateRequested?.Invoke();
         McpLog.Info($"Server source override set to: {picked}");
     }
 }

Consider applying the same fix to the clear button handler:

 clearGitUrlButton.clicked += () =>
 {
     gitUrlOverride.value = string.Empty;
-    EditorPrefs.DeleteKey(EditorPrefKeys.GitUrlOverride);
-    OnGitUrlChanged?.Invoke();
-    OnHttpServerCommandUpdateRequested?.Invoke();
 };

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro