Skip to content

looking at matrixEntrySchema#10192

Merged
rolfyone merged 2 commits intoConsensys:masterfrom
rolfyone:fulu-helper
Dec 1, 2025
Merged

looking at matrixEntrySchema#10192
rolfyone merged 2 commits intoConsensys:masterfrom
rolfyone:fulu-helper

Conversation

@rolfyone
Copy link
Copy Markdown
Contributor

@rolfyone rolfyone commented Dec 1, 2025

investigating a potential inconsistency

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Swap MatrixEntrySchema.create index arguments to pass (cellIndex, blobIndex) when building extended matrices.

  • Helpers (Fulu)
    • Extended matrix construction:
      • In computeExtendedMatrixAndProofs and computeExtendedMatrix within tech/pegasys/teku/spec/logic/versions/fulu/helpers/MiscHelpersFulu.java, update getMatrixEntrySchema().create(...) calls to pass indices as (cellIndex, blobIndex) instead of (blobIndex, cellIndex) for each MatrixEntry.

Written by Cursor Bugbot for commit 888ed72. This will update automatically on new commits. Configure here.

investigating a potential inconsistency
@zilm13 zilm13 self-requested a review December 1, 2025 09:01
Copy link
Copy Markdown
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone marked this pull request as ready for review December 1, 2025 20:07
@rolfyone rolfyone enabled auto-merge (squash) December 1, 2025 20:08
@rolfyone rolfyone merged commit 7c4cd1b into Consensys:master Dec 1, 2025
52 of 53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
@rolfyone rolfyone deleted the fulu-helper branch December 2, 2025 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants