Allow compile() from outside the plugin #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2021 01:46
Cleaned up the class-wp-scss.php file primarily to allow for multiple instances of the Wp_Scss class without conflict with internal variables. Removed almost all global variable references to create a more class based/object oriented structure, including removing direct calls to public class variables and replacing with function calls to retrieve private variables.
shadoath
approved these changes
May 18, 2021
Collaborator
shadoath
left a comment
There was a problem hiding this comment.
Really good work on this. Thank you for the clean-up as well as the added functionality. I added some minor code styling requests (I think these may have been around before your changes but I'm only seeing them now).
class/class-wp-scss.php
Outdated
| $this->compile_method = $compile_method; | ||
| $this->compile_errors = array(); | ||
| $scssc = new Compiler(); | ||
| $this->scssc = new Compiler(); |
Collaborator
There was a problem hiding this comment.
Please match the indent of the = sign with the line above for better code readablity.
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Contributor
Author
|
Thanks, some of them may well have been me, either way I've committed those changes. |
Collaborator
|
Resolves #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the class-wp-scss.php file primarily to allow for multiple instances of the Wp_Scss class without conflict with internal variables.
Removed almost all global variable references to create a more class based/object oriented structure, including removing direct calls to public class variables and replacing with function calls to retrieve private variables.