Fix fatal error class MediaBlock not found, update ScssPHP to 1.11.0 #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
Author
|
Please note that I didn't include or recreate the |
shadoath
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I bumped ScssPHP to latest version, and fixed the "white page of death" people are getting when using this plugin, by adding the full ScssPHP library.
Please note that this could be a breaking change, as ScssPHP now requires PHP 7.2 minimum instead of 5.6.
PHP 7.2 was released on the 30th of November 2017 and is even not supported anymore, so I think it's safe to assume the users of this plugin have at least PHP 7.4 or even 8.