Skip to content

[Web Import] Add CSS gg Import#996

Merged
t-regbs merged 5 commits into
mainfrom
feature/cssgg-svg-import
May 5, 2026
Merged

[Web Import] Add CSS gg Import#996
t-regbs merged 5 commits into
mainfrom
feature/cssgg-svg-import

Conversation

@t-regbs

@t-regbs t-regbs commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Screen.Recording.2026-05-04.at.22.31.29.mov

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@t-regbs t-regbs requested a review from egorikftp May 4, 2026 21:33
@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 971dec11-af35-45df-836a-b536b504f2e5

📥 Commits

Reviewing files that changed from the base of the PR and between 8088562 and 19cd640.

📒 Files selected for processing (20)
  • sdk/compose/icons/api/icons.api
  • sdk/compose/icons/api/icons.klib.api
  • sdk/compose/icons/src/commonMain/kotlin/io/github/composegears/valkyrie/sdk/compose/icons/colored/CssGgLogo.kt
  • tools/idea-plugin/CHANGELOG.md
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/service/PersistentSettings.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/settings/InMemorySettings.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/WebImportFlow.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/WebImportSelectorScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/CssGgImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/data/CssGgIconMetadata.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/data/CssGgIndexParser.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/data/CssGgRepository.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/data/CssGgSvgPathResolver.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/di/CssGgModule.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/domain/CssGgConfigBuilder.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/domain/CssGgUseCase.kt
  • tools/idea-plugin/src/main/resources/messages/Valkyrie.properties
  • tools/idea-plugin/src/test/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/data/CssGgIndexParserTest.kt
  • tools/idea-plugin/src/test/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/data/CssGgSvgPathResolverTest.kt
  • tools/idea-plugin/src/test/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/svg/cssgg/domain/CssGgConfigBuilderTest.kt

Walkthrough

This pull request adds support for the CSS.gg icon provider to the Valkyrie project. Changes include adding a new CssGgLogo icon to the compose icons library, implementing a complete web import flow for CSS.gg icons in the IDE plugin, and establishing the necessary infrastructure to fetch, parse, and convert CSS.gg icons from the jsDelivr CDN. The implementation integrates with existing web import navigation, settings persistence, and icon conversion pipelines.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding CSS.gg import functionality to the web import feature.
Description check ✅ Passed The description includes a changelog checklist with the IntelliJ Plugin CHANGELOG.md marked as updated, fulfilling the template requirement for user-facing changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/cssgg-svg-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

egorikftp
egorikftp approved these changes May 5, 2026
View reviewed changes

@egorikftp egorikftp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool🔥

@t-regbs t-regbs merged commit 89c406e into main May 5, 2026
5 checks passed
@t-regbs t-regbs deleted the feature/cssgg-svg-import branch May 5, 2026 06:17
@t-regbs t-regbs mentioned this pull request May 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egorikftp egorikftp egorikftp approved these changes

Assignees

No one assigned

Labels

feature-intellij-plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-regbs @egorikftp