components/parser/kmp/svg/src/commonTest/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/SVGParserTest.kt (1)

68-129: ⚡ Quick win

Add coverage for group stroke and inherited stroke opacity/miter.

The new tests only assert root stroke color/width/cap/join and group fill. The new branches in SVG.Group.toVectorGroup() and SVG.Child.getSVGStrokeWithDefaults() for group-level stroke cascade plus inherited stroke-opacity / stroke-miterlimit can still regress unnoticed.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@components/parser/kmp/svg/src/commonTest/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/SVGParserTest.kt`
around lines 68 - 129, Add tests that exercise group-level stroke inheritance
and stroke-specific attributes: create an SVG with a <g> that sets stroke
(color, width, lineCap, lineJoin) plus stroke-opacity and stroke-miterlimit,
containing child <path> elements without their own stroke; then assert that
SVG.Group.toVectorGroup() and the stroke produced by
SVG.Child.getSVGStrokeWithDefaults() propagate the group's stroke color,
strokeWidth, strokeLineCap, strokeLineJoin, strokeAlpha (from stroke-opacity),
and strokeLineMiter (from stroke-miterlimit) into the resulting IrStroke (e.g.,
IrStroke.Color with IrColor, strokeAlpha float, strokeLineWidth float,
strokeLineCap enum, strokeLineJoin enum, strokeLineMiter float) so regressions
in the new group-level branching are caught.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

components/parser/kmp/svg/src/commonTest/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/SVGParserTest.kt (1)

130-157: ⚡ Quick win

Consider adding a group-level stroke inheritance test.

The PR claims to propagate inherited fill, stroke, and stroke styling through SVG groups and shapes. The new tests cover:

• ✅ Root stroke → path
• ✅ Root fill (null) → path defaults to black
• ✅ Group fill → path

But there is no test for group stroke → path (e.g., <g stroke="#ff0000" stroke-width="1.5">). Adding it would close the coverage gap and give confidence that the PaintContext cascade works symmetrically for stroke at the group level.

✅ Suggested test skeleton

`@Test`
fun parse_path_with_inherited_group_stroke() {
    val svg = svg(fill = "none") {
        """
        <g stroke="#ff0000" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round">
            <path d="M4 4h16"/>
        </g>
        """
    }

    val actual: List<IrVectorNode> = SVGParser.parse(svg).groups.single().nodes

    assertEquals(
        actual = actual,
        expected = listOf(
            IrVectorNode.IrPath(
                pathFillType = IrPathFillType.NonZero,
                fill = null,
                paths = listOf(
                    IrPathNode.MoveTo(4f, 4f),
                    IrPathNode.RelativeHorizontalTo(16f),
                ),
                fillAlpha = 1f,
                stroke = IrStroke.Color(IrColor(0xFFFF0000)),
                strokeAlpha = 1f,
                strokeLineWidth = 1.5f,
                strokeLineCap = IrStrokeLineCap.Round,
                strokeLineJoin = IrStrokeLineJoin.Round,
                strokeLineMiter = 4f,
            ),
        ),
    )
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@components/parser/kmp/svg/src/commonTest/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/SVGParserTest.kt`
around lines 130 - 157, Add a parallel unit test that verifies group-level
stroke inheritance: create a new test function (e.g.,
parse_path_with_inherited_group_stroke) similar to
parse_path_with_inherited_group_fill that builds an SVG with <g stroke="#ff0000"
stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"><path d="M4
4h16"/></g>, call SVGParser.parse(svg) and assert the single IrVectorNode.IrPath
produced has stroke = IrStroke.Color(IrColor(0xFFFF0000)), strokeAlpha = 1f,
strokeLineWidth = 1.5f, strokeLineCap = IrStrokeLineCap.Round, strokeLineJoin =
IrStrokeLineJoin.Round and strokeLineMiter left at default (4f), while fill
remains null; reference SVGParser.parse, IrVectorNode.IrPath and the
stroke-related properties to locate where to assert.