Skip to content

Reuse animation specs in ZoomFloatingBar#989

Merged
egorikftp merged 1 commit into
mainfrom
task/reuse-animation-spec
May 2, 2026
Merged

Reuse animation specs in ZoomFloatingBar#989
egorikftp merged 1 commit into
mainfrom
task/reuse-animation-spec

Conversation

@egorikftp

@egorikftp egorikftp commented May 2, 2026

Copy link
Copy Markdown
Member

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@coderabbitai

coderabbitai Bot commented May 2, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 86503f3f-85a6-4648-adad-48b08bf8229d

📥 Commits

Reviewing files that changed from the base of the PR and between 7c83d70 and 97f475f.

📒 Files selected for processing (1)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/ZoomFloatingBar.kt

Walkthrough

The ZoomFloatingBar component's animation logic was refactored to reduce code duplication. New reusable animation variables were introduced: enterFromStart/exitToStart for left-side animations and enterFromEnd/exitToEnd for right-side animations. These variables combine expandHorizontally with fadeIn for entry transitions and shrinkHorizontally with fadeOut for exit transitions. Multiple AnimatedVisibility blocks controlling the expanded controls, spacer, and chevrons were updated to use these new variables instead of inline animation definitions.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the required changelog template but lacks substantive content about the changes; it's essentially just the template with no additional context. Add a summary of the changes made (e.g., what animation specs were reused and why) to provide context beyond the changelog reminder.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: refactoring animation specs for code reuse in the ZoomFloatingBar component.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/reuse-animation-spec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp enabled auto-merge (rebase) May 2, 2026 19:28
@egorikftp egorikftp merged commit 57d139d into main May 2, 2026
4 checks passed
@egorikftp egorikftp deleted the task/reuse-animation-spec branch May 2, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-regbs t-regbs t-regbs approved these changes

Assignees

No one assigned

Labels

housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@egorikftp @t-regbs