Skip to content

Introduce Codepoint value class#962

Merged
egorikftp merged 1 commit into
mainfrom
task/introduce-codepoint-value-class
Apr 29, 2026
Merged

Introduce Codepoint value class#962
egorikftp merged 1 commit into
mainfrom
task/introduce-codepoint-value-class

Conversation

@egorikftp

@egorikftp egorikftp commented Apr 27, 2026

Copy link
Copy Markdown
Member

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@egorikftp egorikftp requested a review from t-regbs April 27, 2026 11:19
Base automatically changed from feature/tabler to main April 27, 2026 21:59
@egorikftp egorikftp force-pushed the task/introduce-codepoint-value-class branch from e1cf8cf to c685daa Compare April 28, 2026 08:00
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c70a26d3-c063-47a4-b63b-ac1852b5437e

📥 Commits

Reviewing files that changed from the base of the PR and between 5f6c0a6 and c685daa.

📒 Files selected for processing (11)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/bootstrap/domain/BootstrapUseCase.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/boxicons/domain/BoxIconsUseCase.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/StandardImportScreenUI.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/domain/Codepoint.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/domain/CodepointGlyph.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/model/StandardIcon.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/fontawesome/domain/FontAwesomeUseCase.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/lucide/domain/LucideUseCase.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/remix/domain/RemixUseCase.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/tabler/domain/TablerUseCase.kt
  • tools/idea-plugin/src/test/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/domain/CodepointGlyphTest.kt
💤 Files with no reviewable changes (2)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/StandardImportScreenUI.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/common/domain/CodepointGlyph.kt

Walkthrough

This change introduces a new Codepoint inline value class to encapsulate and validate Unicode codepoint integers. The class provides a toGlyphString() method that converts codepoints to their corresponding characters. The StandardIcon data class is updated to use Codepoint instead of raw Int for its codepoint field. All icon loading use cases—Bootstrap, BoxIcons, FontAwesome, Lucide, Remix, and Tabler—are modified to wrap raw codepoint values with the Codepoint type during icon construction. The previous Int.toGlyphString() extension function is removed, and related tests are updated to work with the new Codepoint type.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Introduce Codepoint value class' directly and clearly describes the main change: adding a new Codepoint value class to wrap Unicode codepoints.
Description check ✅ Passed The PR description matches the template structure with the changelog checklist present, though all items are unchecked, suggesting no user-facing changes were identified by the author.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/introduce-codepoint-value-class

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp merged commit ccfb5a9 into main Apr 29, 2026
3 checks passed
@egorikftp egorikftp deleted the task/introduce-codepoint-value-class branch April 29, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-regbs t-regbs Awaiting requested review from t-regbs

Assignees

No one assigned

Labels

housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@egorikftp