Remove redundant convention project in build-logic#938
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (1)
WalkthroughThe pull request modifies the build configuration by removing the ":convention" project inclusion from the 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
There was a problem hiding this comment.
Pull request overview
This PR removes the standalone :convention project from the build-logic included build and replaces it with a single build-logic Gradle plugin project that directly registers Valkyrie convention plugins.
Changes:
- Removed
include(":convention")from thebuild-logicincluded build settings. - Added a
build-logic/build.gradle.ktsthat registers multiplevalkyrie.*Gradle plugins (jvm/kmp/compose/wasm resources/kover/abi). - Introduced internal build-logic utilities and plugin implementations (KMP/JVM/Compose/Kover/ABI/Wasm resources), plus a dependency exclusion helper.
Reviewed changes
Copilot reviewed 1 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build-logic/src/main/kotlin/io/github/composegears/valkyrie/internal/Project.kt | Adds internal Project/Kotlin extension helpers (KMP/JVM/Compose compiler/Kover) and archive base name configuration. |
| build-logic/src/main/kotlin/io/github/composegears/valkyrie/internal/Plugins.kt | Adds internal helpers to retrieve plugin IDs from the version catalog. |
| build-logic/src/main/kotlin/io/github/composegears/valkyrie/extension/KotlinMultiplatformExtension.kt | Adds a helper to apply standard KMP targets (JVM + wasmJs browser). |
| build-logic/src/main/kotlin/io/github/composegears/valkyrie/Excludes.kt | Adds a Configuration helper to exclude unused Android build-tools transitive deps. |
| build-logic/src/main/kotlin/WasmResourcesPlugin.kt | Introduces a custom plugin to wire wasm JS test resource copying and Karma proxy config generation. |
| build-logic/src/main/kotlin/KoverPlugin.kt | Adds a plugin that applies/configures Kover (Jacoco version). |
| build-logic/src/main/kotlin/KmpPlugin.kt | Adds a plugin to apply/configure Kotlin Multiplatform conventions and archive naming. |
| build-logic/src/main/kotlin/JvmPlugin.kt | Adds a plugin to apply/configure Kotlin JVM conventions and archive naming. |
| build-logic/src/main/kotlin/ComposePlugin.kt | Adds a plugin to apply Compose plugins and configure stability configuration files. |
| build-logic/src/main/kotlin/AbiPlugin.kt | Adds a plugin to enable Kotlin ABI validation and wire it into check. |
| build-logic/settings.gradle.kts | Removes the :convention include from the included build. |
| build-logic/build.gradle.kts | Registers the valkyrie.* Gradle plugins and declares build-logic dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.