tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/EditorText.kt (1)

25-29: Preview doesn't demonstrate EditorText functionality.

The preview renders a plain Text component instead of using the EditorText composable it's meant to showcase. However, since rememberCodeHighlight requires LocalProject context (provided by ProjectPreviewTheme), this preview would need to be updated to use ProjectPreviewTheme like other previews in this PR.

♻️ Suggested fix

+import io.github.composegears.valkyrie.jewel.highlight.rememberCodeHighlight
+
 `@Preview`
 `@Composable`
-private fun EditorTextPreview() = PreviewTheme(alignment = Alignment.Center) {
-    Text(text = "editor text style")
+private fun EditorTextPreview() = ProjectPreviewTheme(alignment = Alignment.Center) {
+    EditorText(code = rememberCodeHighlight(text = "val x: Int = 42"))
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/EditorText.kt`
around lines 25 - 29, The EditorTextPreview currently renders a plain Text
instead of using the EditorText composable and lacks the LocalProject context
required by rememberCodeHighlight; update the preview function EditorTextPreview
to wrap its content in ProjectPreviewTheme (like other previews in this PR) so
LocalProject is provided, and instantiate EditorText (not Text) with an
appropriate sample code string and any required params so rememberCodeHighlight
can run in preview.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/EditorText.kt (1)

25-29: Preview does not exercise the EditorText composable.

The preview renders a plain Text with a hardcoded string instead of using the EditorText composable with rememberCodeHighlight. This means the actual rendering path isn't being previewed. Additionally, other files in this PR use ProjectPreviewTheme (which provides LocalProject), but this preview uses PreviewTheme.

Since rememberCodeHighlight requires LocalProject.current (per CodeHighlight.kt), using ProjectPreviewTheme would be necessary to properly preview EditorText.

Suggested fix

 `@Preview`
 `@Composable`
-private fun EditorTextPreview() = PreviewTheme(alignment = Alignment.Center) {
-    Text(text = "editor text style")
+private fun EditorTextPreview() = ProjectPreviewTheme(alignment = Alignment.Center) {
+    EditorText(code = rememberCodeHighlight(text = "val example: String = \"Hello\""))
 }

Also update the import:

-import io.github.composegears.valkyrie.jewel.tooling.PreviewTheme
+import io.github.composegears.valkyrie.jewel.tooling.ProjectPreviewTheme

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/EditorText.kt`
around lines 25 - 29, The preview currently renders a plain Text instead of
exercising EditorText and doesn't provide LocalProject; update EditorTextPreview
to wrap its content in ProjectPreviewTheme (so LocalProject is available) and
call EditorText using rememberCodeHighlight with a sample code string to
exercise the actual rendering path (keep the PreviewTheme import replaced by
ProjectPreviewTheme import). Ensure you reference EditorTextPreview, EditorText,
rememberCodeHighlight, ProjectPreviewTheme and LocalProject when making the
change.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/highlight/CodeHighlight.kt (1)

33-35: Consider adding project as a remember key.

If the project instance ever changes during the composable's lifecycle, the cached codeHighlighter would become stale. While this is unlikely in typical usage, adding project as a key would make the code more defensive.

♻️ Optional: Add project as remember key

-    val codeHighlighter = remember { CodeHighlighterFactory.getInstance(project).createHighlighter() }
+    val codeHighlighter = remember(project) { CodeHighlighterFactory.getInstance(project).createHighlighter() }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/jewel/highlight/CodeHighlight.kt`
around lines 33 - 35, The remember block that creates codeHighlighter should
include the current project as a key so the cached highlighter is recreated if
LocalProject.current changes; update the remember usage around
CodeHighlighterFactory.getInstance(project).createHighlighter() to pass project
as the key (i.e., remember(project) { ... }) so codeHighlighter is always valid
for the current LocalProject.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro